Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBZ-7831 Fix oracle connector failed to work when the table name contains single quote #5531

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

leoloel
Copy link
Contributor

@leoloel leoloel commented Apr 30, 2024

@leoloel leoloel changed the title DBZ-7831 Fix oracle connector failed to work when the table name cont… DBZ-7831 Fix oracle connector failed to work when the table name contains single quote Apr 30, 2024
@Naros
Copy link
Member

Naros commented Apr 30, 2024

Great catch @leoloel, can you confirm whether you checked if the following 3 methods were affected too in the OracleConenction class: isTableExists, getRowCount, and reselectColumns.

/packit test --labels oracle

@debezium debezium deleted a comment from leoloel Apr 30, 2024
@Naros
Copy link
Member

Naros commented Apr 30, 2024

/packit test --labels oracle

1 similar comment
@Naros
Copy link
Member

Naros commented May 1, 2024

/packit test --labels oracle

Copy link

github-actions bot commented May 2, 2024

Hi @leoloel, thanks for your contribution. Please prefix the commit message(s) with the DBZ-xxx JIRA issue key.

@Naros
Copy link
Member

Naros commented May 2, 2024

HI @leoloel can you please remove the merge commit.

@Naros
Copy link
Member

Naros commented May 3, 2024

I'm sorry @leoloel, could you rebase the work to resolve the conflicts, thanks.

@Naros
Copy link
Member

Naros commented May 3, 2024

/packit test --labels oracle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants