Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBZ-3658 Oracle JDBC driver JDK8 to JDK11 (ojdbc11) 21.11.0.0 #5407

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Naros
Copy link
Member

@Naros Naros commented Mar 19, 2024

https://issues.redhat.com/browse/DBZ-3658

@obabec your favorite task -- we'll need to align the testing farm to contain ojdbc11 21.11.0.0, when you have time 馃榾

  • Check release bits and verify no changes needed for ojdbc8 to ojdbc11.
  • Update driver reference used by the JDBC sink connector.

@Naros Naros added the 2.6 label Mar 19, 2024
@jpechane
Copy link
Contributor

/packit test --labels oracle

@Naros
Copy link
Member Author

Naros commented Mar 19, 2024

@roldanbob wrt docs, I wonder if we shouldn't just change the attribute from ojdbc8-version, now ojdbc11-version to actually just reading ojdbc-version. wdyt? Would this be easy to coordinate for downstream?

@roldanbob
Copy link
Contributor

roldanbob commented Mar 19, 2024

@roldanbob wrt docs, I wonder if we shouldn't just change the attribute from ojdbc8-version, now ojdbc11-version to actually just reading ojdbc-version. wdyt? Would this be easy to coordinate for downstream?

We can easily update the attribute name from ojdbc8-version to ojdbc-version, I think , and then assign the current value to it. That makes sense to me. Upstream, it looks like there are only 3 instances in the sources where we reference the attribute, so it's a pretty painless change.

@Naros
Copy link
Member Author

Naros commented Mar 19, 2024

Sounds good, then I'll modify the PR based on that. Thanks @roldanbob.

@roldanbob
Copy link
Contributor

@Naros Based on the Jira issue, I assume that this affects only 2.6 and later, right? Nothing to turn around for 2.5?

@Naros
Copy link
Member Author

Naros commented Mar 19, 2024

@Naros Based on the Jira issue, I assume that this affects only 2.6 and later, right? Nothing to turn around for 2.5?

That's correct, and it may even be something we hold off until 2.7; deferring that to @jpechane.
Given that we're on the brink of 2.6.CR1, I'd say that may even be the best and safest bet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants