Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make schema extensible #3

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Make schema extensible #3

wants to merge 12 commits into from

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Feb 13, 2019

Demo on Binder

Screenshot from 2019-04-09 00-45-05

This PR adds a GraphQLManager, a LoggingConfigurable which owns the schema and subscription serverr. At present, the schema extension is handled with entrypoints: this could be done with jupyter config, albeit round-aboutly, because of dict merging. The contents and fake subscription are added by default.

What is substantially missing is a compelling place yet for adding an extensible type and not just the top-level schema. Some places that could:

  • Media
    • some media might have actually-extractable metadata, e.g. EXIF on images, so you'd like to be able to get at it.
  • Notebook
    • an extension author might want to extend this for their purposes

Not sure the best route for this yet...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant