Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a11y prs #16

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

a11y prs #16

wants to merge 17 commits into from

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Dec 3, 2023 •
edited

what kind of request is this?

  • a preview site on ReadTheDocs
    • it only adds a jupyak_config.toml
  • a jupyak code change
    • it adds new features, described below

for preview sites

how should a visitor use the preview site?

  1. open a new private browser window
  2. go to https://jupyak--16.org.readthedocs.build/en/16/_static/work/lite/lab/
  3. see the Launcher
  4. use tab one or more times to focus the Python (pyodide) launcher item
  5. press enter to start a new notebook from the launcher
  6. press esc to enter Command Mode
  7. use shift+tab a few times navigate back to Close button for the activity
  8. use delete to close the notebook
  9. accept the dialog default with enter

where is the main discussion?

t03857785/jupyterlab#12

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2023

jupyak-badge 👈 Try it on ReadTheDocs

@bollwyvl
Copy link
Contributor Author

bollwyvl commented Dec 3, 2023

The --ours didn't seem to help, trying -sort -Xtheirs again....

bollwyvl added a commit to bollwyvl/jupyak that referenced this pull request Dec 4, 2023
@bollwyvl
backport of git uptodate change from deathbeds#16
c7dffe7
tonyfast
tonyfast reviewed Dec 4, 2023
View reviewed changes
Copy link
Member

@tonyfast tonyfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adds aria live pull requests to the build

jupyak_config.toml Show resolved Hide resolved
jupyak_config.toml Outdated Show resolved Hide resolved
@tonyfast tonyfast mentioned this pull request Dec 4, 2023
Open
tonyfast
tonyfast reviewed Dec 5, 2023
View reviewed changes
jupyak_config.toml Outdated Show resolved Hide resolved
tonyfast
tonyfast reviewed Dec 6, 2023
View reviewed changes
jupyak_config.toml Outdated Show resolved Hide resolved
@tonyfast tonyfast mentioned this pull request Dec 12, 2023
Merged
@bollwyvl bollwyvl closed this Dec 13, 2023
@bollwyvl bollwyvl reopened this Dec 13, 2023
This was referenced Dec 13, 2023
Closed
Open
@krassowski krassowski mentioned this pull request Dec 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyfast tonyfast tonyfast left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bollwyvl @tonyfast