Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of the use of deallog in step-3 and friends. #16987

Merged
merged 1 commit into from
May 10, 2024

Conversation

bangerth
Copy link
Member

@bangerth bangerth commented May 9, 2024

Simply copy what we already in step-4 and nearly everywhere else.

Fixes #16946 and removes a lot of text from the tutorials. The first use of deallog is now in step-34 (other than 12b and 16b that will eventually go away).

@kronbichler
Copy link
Member

You will need to make the diff file for tests/examples/step-3 in-line with what you changed here, as the tester fails to apply the patch

675c675
< deallog.depth_console(2);
---
> //deallog.depth_console(2);

It seems you want to provide an empty diff file now and adjust the test output.

Simply copy what we already in step-4 and nearly everywhere else.
@bangerth
Copy link
Member Author

Seems to work now.

@masterleinad masterleinad merged commit e8dbf71 into dealii:master May 10, 2024
15 of 16 checks passed
@bangerth bangerth deleted the 3 branch May 10, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the use of deallog from step-3.
3 participants