Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all MMKV files from root folder #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

carlonzo
Copy link

No description provided.

@ddyos
Copy link
Owner

ddyos commented Apr 22, 2021

Thank you.
Add all MMKV files from root folder is a good idea.
But someone may need to set the encrypt key of the file flexibly, you may consider this situation.
#5 is talk about this feature.

@carlonzo
Copy link
Author

That's why I created a public method to get all the descriptors. You are free to replace/add descriptors before giving them to the plugin.

@ddyos
Copy link
Owner

ddyos commented Apr 22, 2021

OK.
Two little problem.
1.Can you rename the method to something like "getAllMMKVDescriptorsFromRootDir"? which will be more accurate.
2.The "defaultMMKV" will be add twice.

By the way.
Should this method be call by default? Or just let the User call it manually when they need?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants