-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge sigs in RBI files with existing documentation #170
Conversation
a7d3a18
to
a31f403
Compare
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #170 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 753 826 +73
=========================================
+ Hits 753 826 +73
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
I had some time to add (limited) The limited support is that we will only attempt to merge documentation if an |
5592a9e
to
d290a46
Compare
a981c4e
to
a752d7c
Compare
ef9a109
to
e297077
Compare
c344657
to
cddc4b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as far as documenting RBIs more accurately 🙂
Hi guys, thanks for building this! Sorry I didn't get a chance to take a look at it before. I'm trying to implement it now but I'm running into I've already doubled the stack, then 10x, by setting Here is the full backtrace with |
@jscheid to be clear, is bumping the
Let me know if you uncover any hints this way. |
There's no stack overflow if I don't specify the RBI files on the command line.
OK, I'll dig in. I just thought you had any ideas just from looking at the backtrace. |
@jscheid Definitely try If |
This PR updates the
sig
handler to check theYARD::Registry
for existing documentation. If found, it will incorporate thesig
information into the existing documentation. Otherwise, it will proceed as before, converting thesig
into YARD documentation for normal processing.wdyt @KaanOzkan @jscheid ❓
Resolves #141