Distinguish unset --*-skip settings from set to the empty string
#662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhansen
force-pushed
the
skip
branch
6 times, most recently
from
8c87590
to
f11d0f6
Compare
This prevents the `%builtinweb` or `%builtinfw` skip defaults from overriding a user's explicitly empty `--web-skip=` or `--fw-skip=` setting. This is technically a backwards-incompatible change: Any config that explicitly sets `--web-skip` or `--fw-skip` to the empty string but depends on the built-in skip behavior will fail. This is unlikely to affect many (if any) users; compatibility concerns are believed to be far less significant than the potential need to turn off the built-in skip.
rhansen
changed the title
*-skip settings from set to the empty string--*-skip settings from set to the empty string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the
%builtinwebor%builtinfwskip defaults from overriding a user's explicitly empty--web-skip=or--fw-skip=setting.This is technically a backwards-incompatible change: Any config that explicitly sets
--web-skipor--fw-skipto the empty string but depends on the built-in skip behavior will fail. This is unlikely to affect many (if any) users; compatibility concerns are believed to be far less significant than the potential need to turn off the built-inskip.