User-friendly pre-release version strings #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhansen
force-pushed
the
version
branch
4 times, most recently
from
e0d2217
to
b4fd011
Compare
|
Quick FYI: I haven't had the time to look at this (or the general build steps for that matter) so far. |
rhansen
force-pushed
the
version
branch
5 times, most recently
from
1ac62aa
to
5f5c29b
Compare
Passing `--version=short` simply prints the version and exits. This will make it possible for a future commit to change `configure.ac` to extract the version string from `ddclient.in` to avoid maintaining the same version string in two places.
This avoids the need to maintain the same version string in two different places.
Perl version strings are flawed in a few ways. Convert them to user-friendly strings when printed so that Git tags and tarball names are easier for downstream distributions to work with.
|
I'm going to go ahead and merge this, though I would appreciate it if someone other than me would look over it to confirm that the approach I took is reasonable. I can easily revert the merge commit and re-do this PR if anyone has any suggestions for improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(multiple commits; please do not squash)
Perl version strings are flawed in a few ways. Convert them to user-friendly strings when printed so that Git tags and tarball names are easier for downstream distributions to work with.
Also tell Autoconf to read the version from
ddclient.into avoid the need to maintain the same version string in two different places.