Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use python -m pip install -U pip on Windows #1200

Merged
merged 1 commit into from
Apr 4, 2018

Conversation

bamarni
Copy link
Contributor

@bamarni bamarni commented Apr 3, 2018

Don't run pip install --upgrade pip on Windows, it started to fail in
our Jenkins node and this is not the right command.

https://jira.mesosphere.com/browse/DCOS_OSS-2332
https://pip.pypa.io/en/stable/installing/#upgrading-pip
pypa/pip#1299

@bamarni
Copy link
Contributor Author

bamarni commented Apr 3, 2018

run all integration tests

Copy link
Contributor

@klueska klueska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better if we could upgrade to a specific version of pip that we know works. Do we know exactly what caused this failure to happen now?

Don't run `pip install --upgrade pip` on Windows, it started to fail in
our Jenkins node and this is not the right command.

https://jira.mesosphere.com/browse/DCOS_OSS-2332
https://pip.pypa.io/en/stable/installing/#upgrading-pip
pypa/pip#1299
@bamarni bamarni changed the title Don't run pip install --upgrade pip Use python -m pip install -U pip on Windows Apr 3, 2018
@bamarni
Copy link
Contributor Author

bamarni commented Apr 3, 2018

run windows integration tests

@bamarni bamarni merged commit 7150fd3 into dcos:master Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants