Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled writing of location and description in DICOM SR file #228

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

MarcoBologna91
Copy link

No description provided.

Copy link
Collaborator

@pieper pieper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to add these concepts be we need to be sure they are coded correctly. Please have a look at what I linked or if you have a rationale for what you picked please and a description with links to the standard for reference.

Also the commit message should start with something like "feat(tid300):" to trigger the semantic release.

Comment on lines 114 to 116
CodeValue: "112041",
CodingSchemeDesignator: "DCM",
CodeMeaning: "Location"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide a link to the definition of this code?

From this document it seems that this code means "Target Lesion Complete Response".

http://dicom.nema.org/medical/dicom/current/output/chtml/part16/chapter_D.html

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we want to use "121226 Approximate spatial location"

"The approximate geometric location on an image or in space where an entity is located."

Comment on lines 135 to 137
CodeValue: "112042",
CodingSchemeDesignator: "DCM",
CodeMeaning: "Description"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly this one appears to mean "Target Lesion Partial Response"

@pieper
Copy link
Collaborator

pieper commented Oct 29, 2021

It looks like the PR got messed up and now has a bunch of conflicts.

Bigger question is about the reason for the changes and how they might related to interoperability and standards (e.g. with dmcqi and highdicom among others). Can you describe your work and put it in perspective?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants