update legend text y calculation #1855 & #1852 #1856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Many thanks! I have checked the code and it seems all fine. The CI testes Edge, Chrome, Firefox, and Safari, so, I guess we are good. This change request will get merged and released as part of the next release. |
kum-deepak
added a commit
to kum-deepak/dc.js
that referenced
this pull request
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After reading about these two issues, I was investigating the cause of this and found that on chrome the
clientHeightwas returning a much smaller value thangetBoundingClientRect().heightwhich was returning more consistent results across environments for me.Please let me know if there are any issues with the code here so I can adjust accordingly.