Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create computedMargins and use it instead of internal margins modific… #1342

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

create computedMargins and use it instead of internal margins modific… #1342

wants to merge 1 commit into from

Conversation

emiljas
Copy link

@emiljas emiljas commented Sep 22, 2017

…ations

@emiljas emiljas mentioned this pull request Sep 22, 2017
Open
@gordonwoodhull
Copy link
Contributor

This is definitely a step in the right direction.

Thanks @emiljas!

@kum-deepak
Copy link
Collaborator

This did not get merged for so long. It is being targeted for dc-v5. In similar lines, using a similar approach, width and height and no longer modified by dc. In dc-v5 all chart configuration is getting moved to conf, so, the margins will move to conf and will not get modified by the charts,

@kum-deepak kum-deepak added this to the dc-v5 milestone Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dc-v5
Projects
None yet
Milestone
dc-v5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@emiljas @gordonwoodhull @kum-deepak