New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix concat macro when fields list is of length 1. #447
base: master
Are you sure you want to change the base?
Conversation
Option: you could also do: CONCAT('', field_list) |
I like that @ericmuijsvanoord – updated the PR! |
Hi @ericmuijsvanoord whats the process for getting this merged? |
See this pull request: #461 |
@jlkravitz any movement here? This is still causing issues with dbt-utils as you outlined in the OP. |
Nothing that I have heard!
Sent from iPhone
…On Tue, Apr 23, 2024 at 3:37 PM Adam Stocks ***@***.***> wrote:
@jlkravitz <https://github.com/jlkravitz> any movement here? This is
still causing issues with dbt-utils as you outlined in the OP.
—
Reply to this email directly, view it on GitHub
<#447 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAWWZK6O52XRBC2243DOVCTY62Z7VAVCNFSM6AAAAAA4TRO3TOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZTGI4DGOJWHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I don't think I can help with this, but there are conflicts that have to be resolved first (GitHub message). |
I can try to pick this up and get the tests to pass. Should I open a new PR? @ericmuijsvanoord |
@astocks : im not a maintainer I think. I'm not able to start the tests. |
This pull request fixes the issue described here.
Should this macro handle the case where
fields|length == 0
, or is that case handled upstream?