Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid recursing when installing a project to a subproject via copytree #9734

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

djbelknap
Copy link

resolves #9719

Problem

When installing a local package that contains the current project as a subfolder (like the integration_tests project in dbt-utils), if the symlink fails the copytree recursively copies the current project repeatedly until the path length limit is reached.

Solution

Use the ignore parameter of copytree to ignore the current project's packages directory to avoid repeated recursion.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR (Let me know if you'd like a test specific to this fix)
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@djbelknap djbelknap requested a review from a team as a code owner March 7, 2024 14:51
Copy link

cla-bot bot commented Mar 7, 2024

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @djbelknap

Copy link
Contributor

github-actions bot commented Mar 7, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@cla-bot cla-bot bot added the cla:yes label Mar 7, 2024
@dbeatty10 dbeatty10 added the community This PR is from a community member label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes community This PR is from a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] dbt deps automatically recognizes projects in subdirectories
2 participants