Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More compact bottom bar #1355

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

More compact bottom bar #1355

wants to merge 4 commits into from

Conversation

vanviegen
Copy link

Description

The multiline and transaction parts of the bottom bar could be rather verbose, causing (import) info not to fit when using a somewhat narrow terminal. This PR removes some verbosity, while hopefully maintaining clarity.

This PR is based on PR #1354 as it touches some of the same code.

Checklist

  • I've added this contribution to the changelog.rst.
  • I've added my name to the AUTHORS file (or it's already there).
  • I installed pre-commit hooks (pip install pre-commit && pre-commit install), and ran black on my code.
  • Please squash merge this pull request (uncheck if you'd like us to merge as multiple commits)

@j-bennet
Copy link
Contributor

j-bennet commented Sep 2, 2022

Hi @vanviegen ,

I see your PR's tests are failing on test_virtual_database. We have some special handling for pgbouncer database, and I suspect transactions wouldn't be supported in that, so you might need to use that check for self.is_virtual_database(). Do you need help with this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants