Skip to content

Commit

Permalink
Trace the completion of a dispatch-sync with a new :sync op-type
Browse files Browse the repository at this point in the history
  • Loading branch information
kimo-k committed Dec 7, 2023
1 parent c97b9e9 commit 81e8f30
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
8 changes: 7 additions & 1 deletion docs/releases/2023.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@

> The re-frame [Clojars page](https://clojars.org/re-frame/) contains dependency coordinates for Maven/deps/Lein.
## 1.4.1 (2023-12-07)

#### Added

- `dispatch-sync` now emits a `:sync` trace to indicate when it has finished. See [re-frame-10x#165](https://github.com/day8/re-frame-10x/issues/165)

## 1.4.0 (2023-11-02)

#### Breaking
Expand All @@ -14,7 +20,7 @@

#### Added
- Interceptors now have an optional `:comment` key. It's a no-op.
- `re-frame.std-interceptors/path` now remembers the path it uses in a `:comment`. ((re-frame-10x#165)[https://github.com/day8/re-frame-10x/issues/165])
- `re-frame.std-interceptors/path` now remembers the path it uses in a `:comment`. ([re-frame-10x#165](https://github.com/day8/re-frame-10x/issues/165))
- `re-frame.alpha` namespace, for testing proposed features (see [flows](https://github.com/day8/re-frame/discussions/795) and [polymorphic subscriptions](https://github.com/day8/re-frame/issues/680#issuecomment-1676487563))

#### Changed
Expand Down
1 change: 1 addition & 0 deletions src/re_frame/router.cljc
Original file line number Diff line number Diff line change
Expand Up @@ -236,4 +236,5 @@
[event-v]
(handle event-v)
(-call-post-event-callbacks event-queue event-v) ;; slightly ugly hack. Run the registered post event callbacks.
(trace/with-trace {:op-type :sync})
nil) ;; Ensure nil return. See https://github.com/day8/re-frame/wiki/Beware-Returning-False

0 comments on commit 81e8f30

Please sign in to comment.