Select latest epoch #389
Merged
Select latest epoch #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimo-k
force-pushed
the
select-latest-epoch
branch
3 times, most recently
from
5167afe
to
6e7073c
Compare
Reduced parentheses, redundant bindings & redundant updates. It wasn't obvious that associng `selected-id` amounted to doing nothing, since that was the original value. Switched to using `cond->`. Now, we explicitly do nothing.
The scroll-to effect didn't work in certain cases. Now, new epochs always scroll because they always mount with a clean state.
#190 Now, selecting any epoch but the latest one causes the selection to stay on it, despite any new epochs arriving.
kimo-k
force-pushed
the
select-latest-epoch
branch
from
6e7073c
to
b7b0a54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.