Keyboard settings

[kimo-k]

#314

• Toggle keyboard event handling in the settings
• Bind the show-panel! key in the settings

[coltnz]

lgtm generally.

I wonder if we shouldn't be changing the default here, given it doesn't work well for Firefox. We'll run straight into xkcd if we do, so perhaps we use a different default on Firefox?

[kimo-k]

Different defaults per browser could work, but could also lead to more confusion. I imagine the new option to set your own binding, and the new docs for programmatically opening the panel, should be relief enough for anyone who is currently hacking their Ctrl-h somehow.

How do we feel about Ctrl-Shift-X? It seems unused by mainstream browsers.

Firefox does use it to switch text direction (such as for Arabic input), but only when a text input element is focused. Conveniently, 10x ignores the key event in this situation.

It is used by VSCode and Teams to open panels, but that's probably okay.

[sirmspencer]

Anything for the readme?

[kimo-k]

Hey @sirmspencer, I did notice an inconsistency in the readme for this. I fixed that & added a mention of the settings. Let me know if any other particulars come up.

[sirmspencer]

Looks good, thanks.

[mike-thompson-day8]

There is mention of ctrl-h in re-frame-template README ... Good idea to bump it's deps in that template too.

…

On Thu, 6 July 2023, 10:37 am Matthew Spencer, ***@***.***> wrote: Looks good, thanks. — Reply to this email directly, view it on GitHub <#386 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAXESIHAMDS4TOSXUDE65WDXOYCENANCNFSM6AAAAAAZKY6G5Y> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>