Add support for "effects" for light (#142) #178
+710
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonvovk
reviewed
Jul 23, 2023
|
Thank you for your work |
martaisty
force-pushed
the
feature/light-effects-list
branch
from
4a0acbf
to
da98b70
Compare
martaisty
force-pushed
the
feature/light-effects-list
branch
from
da98b70
to
2b08ebe
Compare
|
Hi @dawidchyrzynski 👋 The PR is ready for review. P.S.: I managed to generate docs. However, it seems to me that Pipfile might be broken (#231) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review and feel free to suggest any good changes 🙂
The PR closes issue #142
Changes: