-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: refactor to bash compatibility #18
base: main
Are you sure you want to change the base?
Conversation
Thanks for the great contribution, @ndom91! This is a significant change. It will take some time to review and test it. I have one concern, though. This change may break the extension for a developer who only has |
Yeah I can double check and run it with Zsh as well. I have a macbook somewhere.. haha. EDIT: Can confirm the array splitting doesn't work in zsh now. See: gh-clean-branches/gh-clean-branches Lines 43 to 46 in 4b8efdc
gh-clean-branches/gh-clean-branches Line 82 in 4b8efdc
Will work on this shortly EDIT 2: Note - https://unix.stackexchange.com/a/491459 |
@ndom91 Please take a look at a test I made that compares the results of the current code (1st run) to the PR code (2nd run). The branch ✅ The current code doesn't list the branch for deletion - as expected. You are welcome to take a look and push a fix. I promise to test it quickly 😉 |
Why did you make this change
Make it bash compatible and further the reach of your great extension!
Feel free to close if you're a big
zsh
fan and explicitly want to keep it this way.. Otherwise I think it'd be wise to make this more widely compatible! 🎉What have you done in this PR
shfmt
and also fixed allshellcheck
linting errors (other than2207
which is disabled file-wide)What was left to do
Dependencies
- zsh
Checklist: