Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual Challenge - Twitter #54

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

krdmllr
Copy link

@krdmllr krdmllr commented Mar 31, 2019

Here is my entry for the visual challenge, a replica of two pages of the twitter app. I did the whole development on android and only modified the tab bar icons to fit for iOS before taking the screenshots.

Start Profile
image image
image image

I do not think i used any controls that get modified by visuals but i found some places where visuals could have helped me (labels, colors, tab bar).

What went well?

  • Layouting was really easy
  • Frames are really nice to round things
  • The performance is unexpected good when i consider that i nested far more controls than i normaly would ...

What went not so well?

  • I put a content page inside a navigation page inside a tabbed page inside a master detail page ... which works but i could not remove the hamburger icon from the navigation bar and just use the new TitleView. I created my own navigation bar in the end where i could layout everything as i wanted, but i think a simple property to disable the icon would be nice. But i think that is not the scope of visual ;)
  • As you can see the status bar is behaving differently on iOS and Android, i think this happens because i disabled the navigation bar and build my own one. This problem also exists when working with a device that has a notch or if a device has rounded corners.
  • I had to implement an effect to get rid of the image shifting in the android tab bar

What would i like:

  • Some kind of unified safe area for device notches and rounded corners
  • Rounded corners on all controls, i wrap everything in a frame when i want a rounded corner ... would be nice to avoid that rendering and code overhead
  • Unified colors and default colors. I did not set any colors aside from the seperator lines and as you can see the font color is quite different on iOS and Android. I think this should be unified aswell and an easy way to override it would be great.
  • Fully unify the bottom tab bar and give us an easy option to modify the image shifting on android (disable it by default)

image

@krdmllr krdmllr marked this pull request as ready for review March 31, 2019 23:16
@fewbackseven
Copy link

//Great work.. Loved it.. Thanks for sharing. Learned a lot, especially how to work on image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants