Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Apcupsd role #625

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add Apcupsd role #625

wants to merge 1 commit into from

Conversation

codemeister64
Copy link
Contributor

What this PR does / why we need it:
Adds Apcupsd role - tool that allows to retrieve info from connected APC UPS and gracefully shutdown host machine in case of power outage

Which issue (if any) this PR fixes:

Fixes #

Any other useful info:

@codemeister64 codemeister64 changed the title Add Apcupsd role WIP: Add Apcupsd role Dec 17, 2022
davestephens
davestephens requested changes Dec 17, 2022
View reviewed changes
Copy link
Owner

@davestephens davestephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks cool! Please can you fix the linting issues then we should be good to go 👍

@codemeister64 codemeister64 changed the title WIP: Add Apcupsd role Add Apcupsd role Dec 17, 2022
@codemeister64
Copy link
Contributor Author

Hey davestephens!
Thanks for the quick review. I've fixed linting issues. However, one CI job still failing, about yarn.lock, but I'm not sure, that it should be resolved in scope of this PR. Could you please take a look?

@codemeister64
Copy link
Contributor Author

Hey @davestephens!
How it is going? Would you please double-check (and probably merge?) this PR?
Thank in advance!

@codemeister64 codemeister64 force-pushed the apcupsd-role branch 3 times, most recently from 6aeaa37 to 7078a7f Compare February 17, 2024 19:33
@codemeister64
Copy link
Contributor Author

Hi @davestephens! Could you please re-review PR when you get a chance. All linting issues are fixed. Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davestephens davestephens davestephens requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codemeister64 @davestephens