Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub workflow for wheel and sdist building and upload #23

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

djhoese
Copy link

@djhoese djhoese commented Jun 16, 2021

Based on discussion in #22

This is a basically an almost straight copy/paste from vispy's github workflow which we've only used once or twice. I decided to use vispy's workflow instead of some of my other projects that have fancier workflows because vispy is closer to datoviz's build process with freetype and other stuff. We'll see how this goes.

There are a lot of steps I see in the install from source documentation and I'm not sure how many of them transfer to this 1:1. Also, this has the "cibuildwheel" tool to create all the wheels which means some of the build commands have to go into environment variables. It might be easier to put these into scripts (ex. <repos root>/ci/). I'm going to focus on linux first and see if we can get that working.

This won't show up in datoviz's Actions until merged so if you want to see the current status you can go here: https://github.com/djhoese/datoviz/actions

@djhoese
Copy link
Author

djhoese commented Jun 16, 2021

Ah I see you have a "wheel" target in your manage.sh script. I could try using that maybe if you think that would work @rossant

@rossant
Copy link
Contributor

rossant commented Jun 17, 2021

Thanks @djhoese !

Yes, these are the commands that should be used to create binary wheels:

  • Linux: ./manage.sh wheel
  • macOS: ./manage.sh wheel
  • Windows: manage.bat wheel

@rossant rossant added the CI label Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants