feat: Allow specifying a path to a custom js function #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanneskoester
requested changes
Nov 17, 2022
README.md
Outdated
| |-----------------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|---------|---------------------------| | ||
| | link-to-url | Renders a link to the given url with {value} replace by the value of the table. Other values of the same row can be accessed by their column header (e.g. {age} for a column named age). | | | | ||
| | custom | Applies the given js function to render column content. The parameters of the function are similar to the ones defined [here](https://bootstrap-table.com/docs/api/column-options/#formatter) | | | | ||
| | custom-path | Allows to specify a path to a file that contains a js function similar to custom. | | | |
There was a problem hiding this comment.
We should say something about the naming of the function and in general the allowed contents of the file here.
There was a problem hiding this comment.
The name of the function shouldn't matter (added that to the docs) and also pointed to the example of our example report.
johanneskoester
approved these changes
Nov 17, 2022
johanneskoester
pushed a commit
that referenced
this pull request
Nov 17, 2022
🤖 I have created a release \*beep\* \*boop\* --- ## [2.9.0](https://www.github.com/datavzrd/datavzrd/compare/v2.8.1...v2.9.0) (2022-11-17) ### Features * Allow specifying a path to a custom js function ([#267](https://www.github.com/datavzrd/datavzrd/issues/267)) ([1eb1453](https://www.github.com/datavzrd/datavzrd/commit/1eb145338b551285926ff8449ebd90664688f2d3)) ### Bug Fixes * Fix error when rendering empty multi header files ([#268](https://www.github.com/datavzrd/datavzrd/issues/268)) ([9c2b464](https://www.github.com/datavzrd/datavzrd/commit/9c2b4649cc6ab170a048d7a7154625b28f5be309)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the user to write their custom js function in a separate file instead of inside the config.yaml. This cleans up the config when having long custom functions as well as making it possible for the user to have full IDE support when writing the actual javascript.