Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - adding document profile user pattern #509

Merged
merged 7 commits into from May 26, 2023
Merged

WIP - adding document profile user pattern #509

merged 7 commits into from May 26, 2023

Conversation

CamrynCarter
Copy link
Contributor

Work in progress, will be adding additional context on how to use the profile for document tracing.

@CamrynCarter
Copy link
Contributor Author

I believe this will now be adapted as part of the Instaproof documentation.

Copy link
Contributor

@JAG-UK JAG-UK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small but important suggestion

| Asset Attributes | Meaning | Requirement |
|------------------------------|--------------------------------------------------------------------------------|--------------------------------------------------------------------|
| document_document | attachment that points to the most recent version of the document being traced | Optional, can use hash only |
| document_hash_value | hash of the most recent version of the document | Optional, must be present if `document_latest_document` is present |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| document_hash_value | hash of the most recent version of the document | Optional, must be present if `document_latest_document` is present |
| document_hash_value | hash of the most recent version of the document | Optional, must be present if `document_document` is present |

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this makes limited sense in general, as does attaching a withdrawn document

Copy link
Contributor

@JAG-UK JAG-UK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small but important suggestion

Copy link
Contributor

@JAG-UK JAG-UK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small but important suggestion

Co-authored-by: Jon Geater <jon.geater@gmail.com>
Signed-off-by: Henry <55110793+henry739@users.noreply.github.com>
@henry739 henry739 merged commit 22782af into main May 26, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants