New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#3330] feat(spark-connector): use old create table interface to support mult spark version #3333
Conversation
Although we supported legacy interfaces, we still use new interfaces to implement the deprecated interfaces. |
Sorry, I couldn't get your point :( |
One possible way is that we implement this method in different Spark version's module, not in common module to avoid this issue? |
yes, but this introduces redundant code which is located in different spark version's module. And there seems no bad effect to using the old interface. |
We should have all of these methods at same time as follows.
|
No, the basic logic is the same and can be reused in different modules, you can define a common, version independent method. |
the new interface and |
Maybe you needn't to reuse, but we should have the similar interface. Maybe you can use object as the type. WDYT? |
let's delay this until after spark multi version design is finished. cc @jerryshao @qqqttt123 |
What changes were proposed in this pull request?
use old create table interface to support mult spark version
Why are the changes needed?
the current interface was introduced in Spark 3.4
the old create table table interface had better Spark version compatibility.
Fix: #3330
Does this PR introduce any user-facing change?
no
How was this patch tested?
existing test.