Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3210] improve(web): add checking table properties to the web e2e test #3301

Merged
merged 6 commits into from May 15, 2024

Conversation

ch3yne
Copy link
Contributor

@ch3yne ch3yne commented May 8, 2024

What changes were proposed in this pull request?

add checking table properties to the web e2e test

image image

Why are the changes needed?

Fix: #3210

Does this PR introduce any user-facing change?

N/A

How was this patch tested?

IT

@ch3yne ch3yne self-assigned this May 8, 2024
@ch3yne ch3yne marked this pull request as draft May 8, 2024 02:19
@ch3yne ch3yne requested a review from LauraXia123 May 14, 2024 07:30
@ch3yne ch3yne marked this pull request as ready for review May 14, 2024 07:30
@LauraXia123
Copy link
Contributor

@ch3yne Could you add a snapshot to show us what's point of the test case verify?

@LauraXia123
Copy link
Contributor

LauraXia123 commented May 14, 2024

image

we also need a test case to verify show the correct values or not in the scope above.
And if we have Multiple data of sortOrders or Distribution, compare whether the text is spliced by commas.

@LauraXia123
Copy link
Contributor

LGTM

@ch3yne ch3yne requested a review from xunliu May 15, 2024 02:27
@ch3yne ch3yne added the need backport Issues that need to backport to another branch label May 15, 2024
@LauraXia123 LauraXia123 merged commit b24e9a6 into datastrato:main May 15, 2024
22 checks passed
github-actions bot pushed a commit that referenced this pull request May 15, 2024
…st (#3301)

### What changes were proposed in this pull request?

add checking table properties to the web e2e test

<img width="647" alt="image"
src="https://github.com/datastrato/gravitino/assets/17310559/012fcd91-ab31-46a0-8e87-3c5d66ffd21f">

<img width="655" alt="image"
src="https://github.com/datastrato/gravitino/assets/17310559/c226551b-24e2-4c5e-88aa-24c2cfb10c2f">



### Why are the changes needed?

Fix: #3210

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

IT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-0.5 need backport Issues that need to backport to another branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] add checking for table Partitioning, SortOrders, Distribution, and Indexes to the web e2e test
2 participants