Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3186] feat(spark-connector): Support Iceberg Spark Procedure #3258

Merged
merged 15 commits into from May 17, 2024

Conversation

caican00
Copy link
Contributor

@caican00 caican00 commented May 3, 2024

What changes were proposed in this pull request?

Support Iceberg Spark Procedure.

Why are the changes needed?

Support manage Iceberg metadata using Spark SQL.

Fix: #3186

Does this PR introduce any user-facing change?

No.

How was this patch tested?

New ITs.

@caican00 caican00 marked this pull request as draft May 3, 2024 12:48
@caican00 caican00 marked this pull request as ready for review May 14, 2024 07:22
@caican00
Copy link
Contributor Author

Hi @FANNG1 could you help review this pr when you are free?

@FANNG1
Copy link
Contributor

FANNG1 commented May 14, 2024

Hi @FANNG1 could you help review this pr when you are free?

ok

@caican00
Copy link
Contributor Author

comments have been addressed. cc @FANNG1

@caican00
Copy link
Contributor Author

comments have been addressed. cc @FANNG1

@FANNG1 could you help review this again?

@FANNG1
Copy link
Contributor

FANNG1 commented May 16, 2024

LGTM except two comments

@FANNG1
Copy link
Contributor

FANNG1 commented May 17, 2024

@caican00 could you rebase with lattest code?

@caican00
Copy link
Contributor Author

building failed as NameIdentifier cannot be converted to String in CatalogKafkaIT.

/home/runner/work/gravitino/gravitino/catalogs/catalog-kafka/src/test/java/com/datastrato/gravitino/catalog/kafka/integration/test/CatalogKafkaIT.java:181: error: no suitable method found for createCatalog(NameIdentifier,Type,String,String,ImmutableMap<String,String>)
        metalake.createCatalog(
                ^
    method SupportsCatalogs.createCatalog(String,Type,String,String,Map<String,String>) is not applicable
      (argument mismatch; NameIdentifier cannot be converted to String)
    method GravitinoMetalake.createCatalog(String,Type,String,String,Map<String,String>) is not applicable

> Task :catalogs:catalog-kafka:compileTestJava
      (argument mismatch; NameIdentifier cannot be converted to String)

@caican00
Copy link
Contributor Author

@caican00 could you rebase with lattest code?

It is already the latest code

@caican00
Copy link
Contributor Author

caican00 commented May 17, 2024

building failed as NameIdentifier cannot be converted to String in CatalogKafkaIT.

/home/runner/work/gravitino/gravitino/catalogs/catalog-kafka/src/test/java/com/datastrato/gravitino/catalog/kafka/integration/test/CatalogKafkaIT.java:181: error: no suitable method found for createCatalog(NameIdentifier,Type,String,String,ImmutableMap<String,String>)
        metalake.createCatalog(
                ^
    method SupportsCatalogs.createCatalog(String,Type,String,String,Map<String,String>) is not applicable
      (argument mismatch; NameIdentifier cannot be converted to String)
    method GravitinoMetalake.createCatalog(String,Type,String,String,Map<String,String>) is not applicable

> Task :catalogs:catalog-kafka:compileTestJava
      (argument mismatch; NameIdentifier cannot be converted to String)

let's wait #3424 to be merged.

@caican00
Copy link
Contributor Author

@FANNG1 could you please help re-trigger the pipeline? thank you.

@FANNG1 FANNG1 merged commit f7eb7ac into datastrato:main May 17, 2024
22 of 23 checks passed
github-actions bot pushed a commit that referenced this pull request May 17, 2024
### What changes were proposed in this pull request?

Support Iceberg Spark Procedure.

### Why are the changes needed?

Support manage Iceberg metadata using Spark SQL.

Fix: #3186

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?

New ITs.
@FANNG1
Copy link
Contributor

FANNG1 commented May 17, 2024

@caican00 ,merged in main, thanks for your work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Subtask] Support Iceberg Spark Procedure
2 participants