Follow Jsonnet monitoring-mixin structure #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxbrunet
force-pushed
the
feat/dashboards-mixin
branch
from
91dc301
to
f675e8e
Compare
|
Would those rules be related to the sample in #47? |
|
Yes, I think so, the issue also mentions filters, but I would only cover Prometheus alerts/rules |
|
Hello @bradfordcp, would you have time to give this PR a review, please? If you are looking for a baseline, Prometheus and Thanos are sort of the references in term of mixins: More at https://monitoring.mixins.dev/ Please do not hesitate to let me know if you have any questions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diff is fairly large in the Jsonnet files due to changes in indentation, I have also run
jsonnetfmton them, but there are no changes in the generated dashboards at this point.Currently
make-dashboards.shstill uses the Jsonnet library baked into thedatastax/grafonnet-lib:v0.1.3image, but I have locked the Jsonnet library withjbto what I think is the same as the image. So the result should be the same with or without the image, libraries can be upgraded later on if desired.If this PR is accepted, I will propose Prometheus rules in another PR.
Closes #69