Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verbose message #183

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Verbose message #183

wants to merge 2 commits into from

Conversation

evgeniy-r
Copy link
Member

No description provided.

@evgeniy-r evgeniy-r self-assigned this Jul 7, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #183 (add0783) into main (24115d7) will decrease coverage by 0.45%.
The diff coverage is 96.42%.

@@            Coverage Diff             @@
##             main     #183      +/-   ##
==========================================
- Coverage   86.88%   86.42%   -0.46%     
==========================================
  Files          57       57              
  Lines        4002     4029      +27     
==========================================
+ Hits         3477     3482       +5     
- Misses        525      547      +22     
Impacted Files Coverage Δ
...atanymizer_engine/src/transformers/template/mod.rs 93.05% <96.42%> (-4.46%) ⬇️
datanymizer_engine/src/transformer/mod.rs 42.00% <0.00%> (-8.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24115d7...add0783. Read the comment docs.

@gregwebs
Copy link
Contributor

gregwebs commented Dec 8, 2023

This is a massive improvement!
Can this be taken out of Draft state? At least make it a configuration option?

@gregwebs
Copy link
Contributor

@evgeniy-r this worked for me. I pulled it into the branch of unreleased changes that we use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants