-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflow for building on macOS #31
Conversation
Wow -- you "translated" all test scenarios. the "crippled-home" seems stuck -- running for 3h and no output. I think I had a similar problem before: https://github.community/t/no-log-at-all-online-or-in-bundled-download-for-the-last-step-in-the-action/18527 which I forgot details of the resolution, so it might indeed have been what I stated in the last comment there. I also remember that OSX build of git-annex had issues with "too many open files" but why would it be on crippled FS? For now (or forever) IMHO it is ok to kick out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a comment to add version info
but I also wonder what in the longer run would be the best way to reuse step definitions across workflows? we could use jinja2 for these as well as we do for testing extensions, but may be there is a better way now?
run: | | ||
echo "::add-path::/Applications/git-annex.app/Contents/MacOS" | ||
|
||
- name: Checkout this repository for scripts/ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add here a step which would print the version since ATM we follow original build close and git-annex.dmg
does not include version in its filename (unlike what we have for .deb packages, so it is possible to discover version really easy). FWIW -- we could have that step in both linux and osx workflow. git annex version
output could be generally useful since summarizes build params etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
I have canceled it and log appeared -- seems to be a legit issue -- got stuck!
|
I can replicate the problem on my computer; using a FAT32 image as |
needs: build-package | ||
strategy: | ||
matrix: | ||
flavor: [normal, crippled-tmp, crippled-home] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just remove crippled-home
from this list with a comment and url to git annex issue to readd it whenever joey fixes it. I need to do that for the NFS testing I had added recently but had to disable: https://github.com/datalad/datalad-extensions/blob/master/.github/workflows/build-git-annex-debianstandalone.yaml#L60 That issue is fixed in annex but build is failing -- yet to finish troubleshooting in #32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with a comment and url to git annex issue
URL to what issue? #30? This PR? Something else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
git annex issue: https://git-annex.branchable.com/bugs/gets_stuck_in_Remote_Tests___40____63____41___while_running_on_OSX_with_HOME_on_crippled_FS/?updated since that is the one, when fixed, would let us add crippled-home
back to the matrix
ssh setup for testing didn't work out: |
The |
we have switched to use dockerized setup for ssh testing recently in datalad. Why to remove them and not just to install docker ? |
Never mind. I've added a step that I think should install Docker, and I've created a PR for adding "set -eu" to the appropriate script: datalad/datalad#4920 |
run: | | ||
if [ "${{ matrix.version }}" != "release" ]; then | ||
curl -fSsL \ | ||
https://raw.githubusercontent.com/datalad/datalad/master/tools/ci/prep-travis-forssh.sh \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry - I have merged the set -eu
in maint only for now... it will get to master
eventually. no need to change this up ATM.
superseded by #33 |
This is (for now) just a draft created in order to trigger a build and make sure things are working.