fix(ingestion/airflow-plugin): airflow remove old tasks #10485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
dushayntAW
force-pushed
the
fix/ING-447/airflow-not-removing-old-task
branch
2 times, most recently
from
ebd7762
to
49c689c
Compare
treff7es
reviewed
May 23, 2024
| logger.debug("Initiating the cleanup of obsselete data from datahub") | ||
|
|
||
| ingested_dataflow_urns = list( | ||
| self.graph.get_urns_by_filter( |
There was a problem hiding this comment.
I think you should filter for cluster as well; otherwise if user has multiple Airflow instance you will delete dags which you shouldn't.
There was a problem hiding this comment.
I am filtering the entire URN which is already having the cluster i.e. urn:li:dataFlow:(airflow,simple_dag,prod)
So, still we need to match/filter cluster explicitly? or my understanding is wrong.
| airflow_job_urns: List = [] | ||
|
|
||
| for dag in all_airflow_dags: | ||
| flow_urn = builder.make_data_flow_urn( |
There was a problem hiding this comment.
cluster should be passed in if exists
There was a problem hiding this comment.
same as other comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist