New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui/ingest): ingest tab should show with manage ingestion privilege #10483
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a fair enough change! one request about changing the default selected tab to be secrets if they can only view secrets and not ingestion sources.
const [selectedTab, setSelectedTab] = useState<TabType>(TabType.Sources); | ||
const me = useUserContext(); | ||
const { config } = useAppConfig(); | ||
const isIngestionEnabled = config?.managedIngestionConfig.enabled; | ||
const showIngestionTab = | ||
isIngestionEnabled && me && me.platformPrivileges?.manageIngestion; | ||
const showSecretsTab = | ||
isIngestionEnabled && me && me.platformPrivileges?.manageSecrets; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since users can now get here if they can manage ingestion or secrets, let's set the default selectedTab
above on line 53 to TabType.Secrets
if they can only view secrets and not ingestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. Will do, test and then mark this as ready for review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
Checklist