Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingestion/transformer): Add dataset domains based on tags using transformer #10458

Merged
merged 3 commits into from May 15, 2024
Merged

fix(ingestion/transformer): Add dataset domains based on tags using transformer #10458

merged 3 commits into from May 15, 2024

Conversation

sagar-salvi-apptware
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata community-contribution PR or Issue raised by member(s) of DataHub Community labels May 8, 2024
@sagar-salvi-apptware sagar-salvi-apptware changed the title feat(ingestion/transformer): Add dataset domains based on tags using transformer fix(ingestion/transformer): Add dataset domains based on tags using transformer May 8, 2024
@sagar-salvi-apptware sagar-salvi-apptware force-pushed the feat/ING-691/build-transformer-domain-tag branch from 6e6d90e to c9ec5c8 Compare May 8, 2024 13:10
@sagar-salvi-apptware sagar-salvi-apptware force-pushed the feat/ING-691/build-transformer-domain-tag branch from c9ec5c8 to 8eb8d6b Compare May 8, 2024 16:53
@anshbansal anshbansal self-requested a review May 9, 2024 07:37
@anshbansal anshbansal self-assigned this May 9, 2024
@sagar-salvi-apptware sagar-salvi-apptware force-pushed the feat/ING-691/build-transformer-domain-tag branch from 8eb8d6b to a00b987 Compare May 9, 2024 18:08
@dushayntAW
Copy link
Contributor

LGTM

@sagar-salvi-apptware sagar-salvi-apptware force-pushed the feat/ING-691/build-transformer-domain-tag branch from a00b987 to 9787603 Compare May 13, 2024 06:13
@sagar-salvi-apptware sagar-salvi-apptware force-pushed the feat/ING-691/build-transformer-domain-tag branch from 9787603 to a039084 Compare May 13, 2024 06:15
@sagar-salvi-apptware sagar-salvi-apptware marked this pull request as ready for review May 13, 2024 12:31
eboneil
eboneil approved these changes May 14, 2024
View reviewed changes
Copy link
Collaborator

@eboneil eboneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anshbansal anshbansal merged commit 5fbf781 into datahub-project:master May 15, 2024
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eboneil eboneil eboneil approved these changes

@dushayntAW dushayntAW dushayntAW approved these changes

@anshbansal anshbansal Awaiting requested review from anshbansal

Assignees

@anshbansal anshbansal

Labels
community-contribution PR or Issue raised by member(s) of DataHub Community ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sagar-salvi-apptware @dushayntAW @eboneil @anshbansal