Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(metadata-io): stabilize Search tests #10408

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

test(metadata-io): stabilize Search tests #10408

wants to merge 1 commit into from

Conversation

trialiya
Copy link
Contributor

@trialiya trialiya commented May 1, 2024 •
edited

Here are the key improvements:

  • syncAfterWrite: "fixed timeout 1 second" replaced with a guaranteed check that all changes are committed to Elastic/OpenSearch, therefore testConcurrentAddEdge() in SearchGraphServiceTestBase should be completely fixed #3124
  • fixed parallel cases with IndexBuilderTestBase and GraphQueryConfiguration
  • added deduplication to testConcurrentRemoveEdgesFromNode/testConcurrentRemoveNodes (related to #3118)

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment community-contribution PR or Issue raised by member(s) of DataHub Community labels May 1, 2024
@pedro93 pedro93 requested a review from david-leifker May 8, 2024 08:37
@trialiya trialiya force-pushed the stabilize-metadata-io-parallel-tests branch from e47ce9f to bfd85e6 Compare May 13, 2024 06:29
@trialiya trialiya force-pushed the stabilize-metadata-io-parallel-tests branch from bfd85e6 to ae7f316 Compare May 20, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-leifker david-leifker Awaiting requested review from david-leifker

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community devops PR or Issue related to DataHub backend & deployment product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve ElasticSearchGraphServiceTest syncAfterWrite
1 participant
@trialiya