Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module restructure #158

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Module restructure #158

wants to merge 3 commits into from

Conversation

richardhallett
Copy link
Contributor

Purpose

This PR is to demonstrate the new module structure for creating and configuring app services.
Currently just uses OAI as a simple example.

Approach

Terraform modules allow us to reuse code see https://developer.hashicorp.com/terraform/tutorials/modules

Environments Directory - This will be where specific workspace setups using the modules will go
Modules Directory - Where reusable components and services can be configured.

Open Questions and Pre-Merge TODOs

Learning

Terraform docs cover in detail a lot of how to structure this.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant