Add skip_client_lookup option when indexing all datacite dois

[jrhoads]

Purpose

This pull request refactors the import by client method in the DataciteDoi model.

What changed?

A new method lookup_client_and_get_dois has been added, which handles the client lookup and GET operations for DOIs. The logic for aborting the operation has been moved upwards in the import_by_client method for early exit when client_id is blank. An option is introduced to skip client lookup, which is used during indexing.

How to test?

Test the DataciteDoi import operations with and without the skip_client_lookup option and observe the logs for accurate logging information and see if DOIs are imported successfully by client ID.

Why make this change?

The change makes the code cleaner, easier to understand and adds more control over the import operation.

---

Types of changes

• Bug fix (non-breaking change which fixes an issue)

• New feature (non-breaking change which adds functionality)

• Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

• Be humble in the language and feedback you give, ask don't tell.
• Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
• Offer suggestions on how to improve code e.g. simplification or expanding clarity.
• Ensure you give reasons for the changes you are proposing.

[jrhoads]

• Align OtherDoi bulk indexing with DataciteDoi bulk indexing. #1187
• Add skip_client_lookup option when indexing all datacite dois #1181 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jrhoads and the rest of your teammates on Graphite