search for events using sub_id+obj_id+source_id+relation_type_id #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrhoads
reviewed
Dec 18, 2023
app/controllers/events_controller.rb
Outdated
| @@ -46,7 +46,13 @@ def create | |||
|
|
|||
| def update | |||
| @event = Event.where(uuid: params[:id]).first | |||
There was a problem hiding this comment.
Do both of these searches get called?
Should the second one get an if @event.blank? much like line 58
There was a problem hiding this comment.
Heyo @jrhoads. Both of these should certainly not get called. The lookup via UUID will get removed. Sorry I should have made this PR a draft. Wanted to see why the builds are failing 😢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
closes: #1073
Approach
Open Questions and Pre-Merge TODOs
Learning
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Reviewer, please remember our guidelines: