Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate remaining pages to app router #359

Merged
merged 11 commits into from
May 20, 2024

Conversation

bklaing2
Copy link
Contributor

@bklaing2 bklaing2 commented May 7, 2024

Purpose

closes: #337

Approach

Open Questions and Pre-Merge TODOs

  • I moved the statistics query to run on the client, it was previously running on the server.
  • I removed the beta page

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

Copy link

cypress bot commented May 7, 2024

Passing run #1211 ↗︎

0 55 0 0 Flakiness 0

Details:

Merge d22b13d into a9d9ffd...
Project: akita Commit: 596bbc4423 ℹ️
Status: Passed Duration: 02:20 💡
Started: May 20, 2024 12:41 PM Ended: May 20, 2024 12:43 PM

Review all test suite changes for PR #359 ↗︎

@bklaing2 bklaing2 self-assigned this May 7, 2024
Copy link

cypress bot commented May 7, 2024

1 flaky test on run #1213 ↗︎

0 55 0 0 Flakiness 1

Details:

Migrate remaining pages to app router (#359)
Project: akita Commit: 5b00d35b0e
Status: Passed Duration: 04:13 💡
Started: May 20, 2024 1:00 PM Ended: May 20, 2024 1:05 PM
Flakiness  cypress/e2e/fundrefContainer.test.ts • 1 flaky test • Tests

View Output

Test Artifacts
FundrefContainer > id Test Replay Screenshots

Review all test suite changes for PR #359 ↗︎

@bklaing2 bklaing2 requested a review from jrhoads May 8, 2024 08:57
src/app/beta/page.tsx Outdated Show resolved Hide resolved
@bklaing2 bklaing2 merged commit 5b00d35 into master May 20, 2024
10 of 11 checks passed
@bklaing2 bklaing2 deleted the migrate-remaining-pages-to-app-router branch May 20, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate standalone pages to app router
2 participants