Fixing bad links in episodes/setup.R #433
Conversation
🆗 Pre-flight checks passed 😃This pull request has been checked and contains no modified workflow files, spoofing, or invalid commits. It should be safe to Approve and Run the workflows that need maintainer approval. |
|
@AndyBunn thank you for submitting a PR to our repository. Could you please clarify where you are getting an error from and what it states on your machine? When rendering the site, I am not currently getting any broken download links. |
|
Oops. Sorry. I see it on the website:
https://datacarpentry.org/r-raster-vector-geospatial/01-raster-structure.html
A
From: Drake Asberry ***@***.***>
Date: Sunday, March 24, 2024 at 12:24 PM
To: datacarpentry/r-raster-vector-geospatial ***@***.***>
Cc: Andy Bunn ***@***.***>, Mention ***@***.***>
Subject: Re: [datacarpentry/r-raster-vector-geospatial] Fixing bad links in episodes/setup.R (PR #433)
@AndyBunn<https://github.com/AndyBunn> thank you for submitting a PR to our repository. Could you please clarify where you are getting an error from and what it states on your machine? When rendering the site, I am not currently getting any broken download links.
—
Reply to this email directly, view it on GitHub<#433 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AC7UCXIJU7RZG63M6KOKU6TYZ4R7RAVCNFSM6AAAAABFE6X5E6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJWHEYTGOBYGQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Thank you for clarifying. Nice catch. Just a quick few things to do before we can merge into repo.
|
|
I maybe did it correctly? I'm pretty much an idiot when it comes to GitHub. |
If this pull request addresses an open issue on the repository, please add 'Closes #NN' below, where NN is the issue number.
Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes.
In episodes/setup.R the urls for the natural earth data downloads were pointing to a redirect (302) which broke download.file(). I adjusted those in episodes/setup.R which should fix the problem.
If any relevant discussions have taken place elsewhere, please provide links to these.
For more guidance on how to contribute changes to a Carpentries project, please review the Contributing Guide and Code of Conduct.
Please keep in mind that lesson Maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at team@carpentries.org.