Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix column renaming exercise #299

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marijane
Copy link
Contributor

The sentence "Edit the name of the species column to species_abbreviation. Then, rename scientificName 2 to species." seems like it should be step five in the exercise instead of following the exercise as it currently does -- it's giving away the answer!

The sentence "Edit the name of the `species` column to `species_abbreviation`. Then, rename `scientificName 2` to `species`." seems like it should be step five in the exercise instead of following the exercise as it currently does -- it's giving away the answer!
@github-actions
Copy link

github-actions bot commented Sep 21, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/datacarpentry/OpenRefine-ecology-lesson/compare/md-outputs..md-outputs-PR-299

The following changes were observed in the rendered markdown documents:

 04-transforming-data.md | 5 ++---
 md5sum.txt              | 2 +-
 2 files changed, 3 insertions(+), 4 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-09-22 07:03:32 +0000

github-actions bot pushed a commit that referenced this pull request Sep 22, 2023
@bencomp
Copy link
Contributor

bencomp commented Sep 22, 2023

Hmm, I can see what you mean, but it could also be step 3 in the list that started above the exercise. The 4th item of the solution provides two ways of solving the issue and then it looks like the lesson chooses one way to continue the lesson flow. That could mean we need a different change.

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants