Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sparse compatibility layer. #134

Merged
merged 12 commits into from May 17, 2024
Merged

Conversation

hameerabbasi
Copy link
Contributor

This PR adds a compatibility layer for sparse.

@hameerabbasi hameerabbasi changed the title WIP: Add sparse compatibility layer. Add sparse compatibility layer. May 3, 2024
@hameerabbasi
Copy link
Contributor Author

Given that JAX also doesn't have CI and we already have CI for the Array API in sparse, I feel this is complete.

@hameerabbasi hameerabbasi marked this pull request as ready for review May 13, 2024 06:02
@asmeurer
Copy link
Member

Can you update the docs. If you search for the places where JAX is mentioned you can also mention sparse there in the same way.

@asmeurer
Copy link
Member

Also sparse can be added to the same the places where jax is tested in the tests.

@hameerabbasi hameerabbasi marked this pull request as draft May 15, 2024 04:56
@hameerabbasi
Copy link
Contributor Author

Can you update the docs. If you search for the places where JAX is mentioned you can also mention sparse there in the same way.

Done in d3c6636

Also sparse can be added to the same the places where jax is tested in the tests.

Done in 855756d

@hameerabbasi hameerabbasi marked this pull request as ready for review May 15, 2024 05:31
@hameerabbasi
Copy link
Contributor Author

hameerabbasi commented May 15, 2024

CI seems to fail with:

E           ImportError: Numba needs NumPy 1.22 or greater. Got NumPy 1.21.

I don't see how we can get around this; Numba is one of the requirements of sparse. We also dropped 3.9 before adding Array API support.

Edit: Only testing sparse for Py310+. See 9c40867.

@hameerabbasi
Copy link
Contributor Author

The PyTorch failures seem to be unrelated to this PR, from a quick glance.

@asmeurer
Copy link
Member

@hameerabbasi
Copy link
Contributor Author

@asmeurer
Copy link
Member

OK, this looks good. Let me know if you need this released soon. Otherwise, it might take a bit because I need to figure out what is going on with the PyTorch failures.

@asmeurer asmeurer merged commit 8b9e0c0 into data-apis:main May 17, 2024
31 of 35 checks passed
@hameerabbasi hameerabbasi deleted the sparse-compat branch May 18, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants