Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add det/slogdet workaround for dask #133

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lithomas1
Copy link
Contributor

No description provided.

@asmeurer
Copy link
Member

asmeurer commented Apr 23, 2024

Is this needed for a downstream package?

This is right on the border of something that's too algorithmically complex to be appropriate for array-api-compat https://data-apis.org/array-api-compat/#scope. I'm not saying I'm rejecting it outright, but it does worry me. Note that the array API test suite does not have any sort of numerical tests for these functions. It only tests basic things like that the output shapes and dtypes are correct (see https://github.com/data-apis/array-api-tests/blob/e38ce3466e596ed2b8fa4638f161f5563ded81a8/array_api_tests/test_linalg.py#L219-L228 and https://github.com/data-apis/array-api-tests/blob/e38ce3466e596ed2b8fa4638f161f5563ded81a8/array_api_tests/test_linalg.py#L568-L607). At the very least I would start with taking existing tests from other libraries and seeing if they can be adapted for these functions.

Another thing to consider here is whether this can be upstreamed to Dask itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants