Added tests to plotly-charts.ipynb #557
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adnanhemani
requested changes
Dec 23, 2022
There was a problem hiding this comment.
Hi, thanks for this. But _split_column_and_labels should have tests within test_tables.py. And _rowExcluder and _rowTaker already have tests defined in the method docs.
Can you please make the changes? The tests regarding hist_of_counts for the Plotly library seem fine otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ ] Wrote test for feature
[x] Added changes to CHANGELOG.md
Changes proposed:
Added tests for _split_column_and_labels, hist_of_counts, _rowTaker, _rowExcluder and checked for user warnings.