Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add plots to illustrate what the optimizer does #11072

Merged
merged 6 commits into from Apr 30, 2024
Merged

Add plots to illustrate what the optimizer does #11072

merged 6 commits into from Apr 30, 2024

Conversation

phofl
Copy link
Collaborator

@phofl phofl commented Apr 25, 2024

  • Closes #xxxx
  • Tests added / passed
  • Passes pre-commit run --all-files

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 25, 2024 •
edited

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

     15 files  ± 0       15 suites  ±0   3h 25m 50s ⏱️ + 3m 59s
 13 121 tests ± 0   12 187 ✅ +121     931 💤 +  2  3 ❌  - 121 
162 468 runs   - 18  142 363 ✅ +  1  20 102 💤 +186  3 ❌  - 181 

For more details on these failures, see this check.

Results for commit 10fc7e0. ± Comparison against base commit dafb6ac.

This pull request skips 2 tests. 
dask.tests.test_spark_compat
dask.tests.test_typing

♻️ This comment has been updated with latest results.

@phofl @hendrikmakait
Update docs/source/dataframe-optimizer.rst
cffe539 
Co-authored-by: Hendrik Makait <hendrik@makait.com>
hendrikmakait
hendrikmakait reviewed Apr 30, 2024
View reviewed changes
docs/source/images/optimizer/avoiding-shuffles.svg Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Maybe replace "Trivial Join" with "Pre-Partitioned Join"?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like trivial more, it sounds better to me

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case I suggest reverting cffe539 to stay consistent.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on Trivial over Pre-Partitioned. My guess is that most readers won't understand what PrePartitioned means.

phofl and others added 3 commits April 30, 2024 18:51
@phofl phofl merged commit 814ed3b into dask:main Apr 30, 2024
25 of 26 checks passed
@phofl phofl deleted the docs_repartitioning branch April 30, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrocklin mrocklin mrocklin left review comments

@hendrikmakait hendrikmakait hendrikmakait left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@phofl @mrocklin @hendrikmakait