Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement setting config variables that contain the dot in name #10992

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dbalabka
Copy link

@dbalabka dbalabka commented Mar 11, 2024

These changes add the possibility of setting config variables that contain . in the name.

Using env variables:

DASK_DISTRIBUTED__LOGGING__DISTRIBUTED=info
DASK_DISTRIBUTED__LOGGING__DISTRIBUTED--CLIENT=info
DASK_DISTRIBUTED__LOGGING__DISTRIBUTED--SCHEDULER=info
DASK_DISTRIBUTED__LOGGING__DISTRIBUTED--SHUFFLE=info

Using set(...):

dask.config.set({
  'distributed.logging.distributed': 'info',
  'distributed.logging.distributed__client': 'info',
  'distributed.logging.distributed__scheduler': 'info',
  'distributed.logging.distributed__shuffle': 'info',
})

Both options results into the following configuration:

dask.config.get("distributed.logging")
{'distributed': 'info', 'distributed.client': 'info', 'distributed.scheduler': 'info', 'distributed.shuffle': 'info'}

Discussion

I see how we can avoid adjusting dask.config.set() logic by improving collect_env().

@GPUtester
Copy link
Collaborator

Can one of the admins verify this patch?

Admins can comment ok to test to allow this one PR to run or add to allowlist to allow all future PRs from the same author to run.

Copy link
Contributor

github-actions bot commented Mar 11, 2024

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

     15 files  ±0       15 suites  ±0   3h 17m 58s ⏱️ - 1m 58s
 13 105 tests ±0   12 159 ✅ ±0     930 💤 ±0  16 ❌ ±0 
162 239 runs  ±0  141 987 ✅ +2  20 236 💤  - 2  16 ❌ ±0 

For more details on these failures, see this check.

Results for commit ce52070. ± Comparison against base commit f201f7e.

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants