dask.array.tensordot
bugfix: ensure axes
are positive / add tests for negative axes
#10812
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
numpy.tensordot
accepts negative axes, negative axes indask.array.tensordot
were giving wrong results. This bug is easily fixed by ensuring that the left axes are positive before the sum-reduction step.dask.array.tensordot
bug: negative values in argumentaxes
give wrong results. #10811pre-commit run --all-files
Co-authored-by: Sepand Kashani sepand@kashani.ch