Add dask.array.array_equal
#10740
Add dask.array.array_equal
#10740
Conversation
|
Can one of the admins verify this patch? Admins can comment |
|
The failing test appears to be unrelated to this pull request. |
hendrikmakait
added
array
needs review
|
I updated this pull request so it includes the optimization in numpy/numpy#24663. |
bouweandela
force-pushed
the
add-array-equal
branch
from
c7fce55
to
6ac5e6c
Compare
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files + 12 15 suites +12 3h 29m 27s ⏱️ + 3h 24m 24s For more details on these failures, see this check. Results for commit 6ac5e6c. ± Comparison against base commit dde25d9. |
| @@ -1896,6 +1896,149 @@ def test_where_incorrect_args(): | |||
| assert "either both or neither of x and y should be given" in str(e) | |||
|
|
|||
|
|
|||
| def _test_array_equal_parametrizations(): | |||
There was a problem hiding this comment.
Could you use a proper fixture here?
There was a problem hiding this comment.
I'm not sure I understand, could you explain in a bit more detail what you would like to see, please? I read through all the documentation on pytest.mark.parametrize and fixtures, but I cannot find how using a fixture would facilitate parametrizing a test. Or do you mean to drop pytest.mark.parametrize and write a single test that loops over all the test cases? That would prevent running the tests in parallel though.
As a side note: this test setup was copied from numpy/_core/tests/test_numeric.py, so it might be easier for future maintenance to keep modifications to a minimum.
Add the function
dask.array.array_equal.pre-commit run --all-files