Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dask.array.fft mismatch with Numpy's interface (add support for norm argument) #10665

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

joanrue
Copy link
Contributor

@joanrue joanrue commented Dec 4, 2023

  • Closes Support norm in dask.array.fft #3280 where norm argument was needed to match numpy.fft API.
  • Adds tests to validate that the different values for norm match NumPy's.
  • Passes pre-commit run --all-files

scipy.fftpack is now legacy as it doesn't follow numpy.fft API and they suggest using scipy.fft scipy/scipy#19005
Not dask.array.fft follows same API as numpy.fft
@GPUtester
Copy link
Collaborator

Can one of the admins verify this patch?

Admins can comment ok to test to allow this one PR to run or add to allowlist to allow all future PRs from the same author to run.

@github-actions github-actions bot added the array label Dec 4, 2023
@joanrue joanrue changed the title Fix dask.array.fft mismatch with Numpy's interface (add support for norm argument) Fix dask.array.fft mismatch with Numpy's interface (add support for norm argument) Jan 11, 2024
Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

     15 files  ±0       15 suites  ±0   3h 49m 58s ⏱️ + 3m 5s
 12 941 tests ±0   11 620 ✅ + 23     917 💤  -  12  404 ❌  - 10 
160 329 runs  ±0  143 168 ✅ +138  16 757 💤  - 127  404 ❌  - 10 

For more details on these failures, see this check.

Results for commit a985de3. ± Comparison against base commit cdcddb6.

This pull request removes 28 and adds 28 tests. Note that renamed tests count towards both.
dask.array.tests.test_fft ‑ test_wrap_fftns[float32-fft2-scipy.fftpack]
dask.array.tests.test_fft ‑ test_wrap_fftns[float32-fftn-scipy.fftpack]
dask.array.tests.test_fft ‑ test_wrap_fftns[float32-ifft2-scipy.fftpack]
dask.array.tests.test_fft ‑ test_wrap_fftns[float32-ifftn-scipy.fftpack]
dask.array.tests.test_fft ‑ test_wrap_fftns[float32-irfft2-scipy.fftpack]
dask.array.tests.test_fft ‑ test_wrap_fftns[float32-irfftn-scipy.fftpack]
dask.array.tests.test_fft ‑ test_wrap_fftns[float32-rfft2-scipy.fftpack]
dask.array.tests.test_fft ‑ test_wrap_fftns[float32-rfftn-scipy.fftpack]
dask.array.tests.test_fft ‑ test_wrap_fftns[float64-fft2-scipy.fftpack]
dask.array.tests.test_fft ‑ test_wrap_fftns[float64-fftn-scipy.fftpack]
…
dask.array.tests.test_fft ‑ test_wrap_fftns[float32-fft2-scipy.fft]
dask.array.tests.test_fft ‑ test_wrap_fftns[float32-fftn-scipy.fft]
dask.array.tests.test_fft ‑ test_wrap_fftns[float32-ifft2-scipy.fft]
dask.array.tests.test_fft ‑ test_wrap_fftns[float32-ifftn-scipy.fft]
dask.array.tests.test_fft ‑ test_wrap_fftns[float32-irfft2-scipy.fft]
dask.array.tests.test_fft ‑ test_wrap_fftns[float32-irfftn-scipy.fft]
dask.array.tests.test_fft ‑ test_wrap_fftns[float32-rfft2-scipy.fft]
dask.array.tests.test_fft ‑ test_wrap_fftns[float32-rfftn-scipy.fft]
dask.array.tests.test_fft ‑ test_wrap_fftns[float64-fft2-scipy.fft]
dask.array.tests.test_fft ‑ test_wrap_fftns[float64-fftn-scipy.fft]
…

@joanrue
Copy link
Contributor Author

joanrue commented Mar 21, 2024

Hi! I'm reaching out to see if there's anything more I can do to facilitate the review process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support norm in dask.array.fft
2 participants